Add support for V3 Nodes with backwards compatibility #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After updating comfyui to newest version I've started getting
'JoinImageWithAlpha' object has no attribute 'join_image_with_alpha'error inLayeredDiffusionDecodeRGBANode. It's apparently related to V3 Nodes MigrationThis PR contains simple check whether V3 or V1 is available, keeping backwards compatibility if older env is used.
I don't have much experience with ComfyUi Nodes and haven't tested this extensively, but seems to be fixing issue and works for V1 as well as V3. Feel free to merge it.
I would also appreciate any insight whether this implementation will be maintained. I've found it useful for something I've recently built and would be great to know if there will be any fixes released when needed etc. or should I solely rely on my own fork. Some providers like Replicate also links to this repo when custom workflows are being used, so when they'll update their dependencies, workflows for some people will likely crash.