fix: skip Content-Length validation when Content-Encoding is present (#1642)#1717
Open
bibekmhj wants to merge 3 commits intohttpie:masterfrom
Open
fix: skip Content-Length validation when Content-Encoding is present (#1642)#1717bibekmhj wants to merge 3 commits intohttpie:masterfrom
bibekmhj wants to merge 3 commits intohttpie:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a response has Content-Encoding (e.g. gzip), the requests library
transparently decompresses the body. This means the bytes written to disk
are the uncompressed size, which exceeds Content-Length (the compressed
size per RFC 9110 §8.6). Comparing the two causes a false 'Incomplete
download' error.
Fix: set total_size=None when Content-Encoding is present, skipping the
completeness check — consistent with curl, wget, and browser behaviour.
Fixes #1642
Fixes #1554
Related: #1701"