Upgrade devcontainer features and pipx package references #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades multiple devcontainer feature definitions by switching to the new devcontainers-extra/features/pipx-package:1.1.9 image and bumping each feature’s own version to 2.0.0 to ensure compatibility with the latest pipx packaging feature set.
- Update all
install.shscripts to use theghcr.io/devcontainers-extra/features/pipx-package:1.1.9image instead of the olddevcontainers-contribreference. - Bump the
versionfield in eachdevcontainer-feature.jsonfrom1.xto2.0.0. - Update
installsAfterblocks to reference the newdevcontainers-extrapipx feature.
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/rstcheck/install.sh | Switched pipx package image to devcontainers-extra:1.1.9. |
| src/rstcheck/devcontainer-feature.json | Bumped feature version to 2.0.0; updated installsAfter. |
| src/pyupgrade/install.sh | Switched pipx package image to devcontainers-extra:1.1.9. |
| src/pyupgrade/devcontainer-feature.json | Bumped feature version to 2.0.0; updated installsAfter. |
| src/pytest/install.sh | Switched pipx package image to devcontainers-extra:1.1.9. |
| src/pytest/devcontainer-feature.json | Bumped feature version to 2.0.0; updated installsAfter. |
| src/pymarkdownlnt/install.sh | Switched pipx package image to devcontainers-extra:1.1.9. |
| src/pymarkdownlnt/devcontainer-feature.json | Bumped feature version to 2.0.0; updated installsAfter. |
| src/pycqa/install.sh | Switched pipx package image to devcontainers-extra:1.1.9 for each tool. |
| src/pycqa/devcontainer-feature.json | Bumped bundle version to 2.0.0; updated installsAfter. |
| src/pyadr/install.sh | Switched pipx package image to devcontainers-extra:1.1.9. |
| src/pyadr/devcontainer-feature.json | Bumped feature version to 2.0.0; updated installsAfter. |
| src/django-upgrade/install.sh | Switched pipx package image to devcontainers-extra:1.1.9. |
| src/django-upgrade/devcontainer-feature.json | Bumped feature version to 2.0.0; updated installsAfter. |
| install \ | ||
| devcontainer-feature \ | ||
| "ghcr.io/devcontainers-contrib/features/pipx-package:1.1.7" \ | ||
| "ghcr.io/devcontainers-extra/features/pipx-package:1.1.9" \ |
There was a problem hiding this comment.
[nitpick] Consider centralizing the pipx-package image reference (ghcr.io/devcontainers-extra/features/pipx-package:1.1.9) into a shared variable or helper script so you don’t need to update the literal in every install.sh when bumping versions in the future.
Suggested change
| "ghcr.io/devcontainers-extra/features/pipx-package:1.1.9" \ | |
| "$PIPX_PACKAGE_IMAGE" \ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade the versions of multiple devcontainer features and update pipx package references to ensure compatibility and access to the latest features.