Fix CI for ruby@3.2.x-rails@7.2.x
#764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to [#761][] and [883a19e][] The changes introduced in #761 were passing for all Ruby and Rails version combinations with the exception of `ruby@3.1` and `rails@7.1`. Following that commit's merging, the change in [883a19e][] removed support for `ruby@3.1` and replaced it with `ruby@3.2`. However, that version still fails in the same way that its preceding commit fails. This commit guards the assertion so that it is skipped for any `ruby@3.2` entry in the CI matrix. Rather than resolve the issue, this commit aims to restore a green suite for other commits to be merged into. We can resolve the underlying issue in the future, or wait until [March of 2026 when Ruby 3.2 becomes EOL][eol]. [#761]: #761 [883a19e]: 883a19e [eol]: https://www.ruby-lang.org/en/downloads/branches/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #761 and 883a19e
The changes introduced in #761 were passing for all Ruby and Rails version combinations with the exception of
ruby@3.1andrails@7.1. Following that commit's merging, the change in 883a19e removed support forruby@3.1and replaced it withruby@3.2.However, that version still fails in the same way that its preceding commit fails.
This commit guards the assertion so that it is skipped for any
ruby@3.2entry in the CI matrix. Rather than resolve the issue, this commit aims to restore a green suite for other commits to be merged into. We can resolve the underlying issue in the future, or wait until March of 2026 when Ruby 3.2 becomes EOL.