Acccept meta tag string arguments as well #754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenkel
force-pushed
the
feat/meta-tag-string-arguments
branch
from
407a2e3 to
9660dc4
Compare
frenkel
changed the title
frenkel
changed the title
Contributor
|
@frenkel could you add some tests to cover these values? |
seanpdoyle
approved these changes
Nov 21, 2025
seanpdoyle
force-pushed
the
feat/meta-tag-string-arguments
branch
from
9660dc4 to
84dd561
Compare
seanpdoyle
force-pushed
the
feat/meta-tag-string-arguments
branch
from
84dd561 to
49f3666
Compare
Contributor
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR you would get this error:
Information for cause: ArgumentError (Invalid refresh option 'morph')for this code:
<%= turbo_refresh_method_tag "morph" %>This error message was a real head scratcher until I read the code and realized I had used the wrong type. I think strings are fine to accept as well, this PR fixes it.