Add support for Model Class in Action and Frame helpers #597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated turbo_stream_action_tag and turbo_frame_tag helpers to accept a Model Class as their target.
seanpdoyle
force-pushed
the
better-dom_id-support
branch
from
7376534 to
6703a1d
Compare
Contributor
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR updates the
turbo_frame_tagandturbo_stream_action_taghelpers to support passing a class argument in the same wayActionView::RecordIdentifier#dom_iddoes.I updated the methods to also check for a
Classsincedom_idessentially does that.I didn't see any contributor docs so I'm not sure if I missed something.
Thanks.