Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
alexbouchardd
approved these changes
Mar 25, 2026
Allow disabling the webhook header prefix by setting it to whitespace (e.g. " "). The provider trims whitespace, so " " effectively sets the prefix to empty string. - Config `toConfig()` converts string→*string: empty=""→nil (default), non-empty→&value - `WithHeaderPrefix(*string)`: nil keeps default, non-nil applies with TrimSpace - Add tests for nil/empty/whitespace/custom prefix in both providers Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
alexluong
force-pushed
the
feat/575-empty-header-prefix
branch
from
5796fbf to
83c547f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
header_prefix: " "orDESTINATIONS_WEBHOOK_HEADER_PREFIX=" ")stringtype (env/v9 doesn't support*string), converts to*stringat thetoConfig()boundaryWithHeaderPrefix(*string):nilkeeps default prefix, non-nil applies value withstrings.TrimSpace(whitespace → empty = no prefix)new("value")syntax for pointer literals in testsHow it works
""nilx-outpost-orwebhook-)" "(whitespace)&" "→ trimmed to"""x-custom-"&"x-custom-"Test plan
make testall greengofmtclean🤖 Generated with Claude Code