Skip to content

Fix Kafka integration test SASL configuration #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexluong merged 1 commit into from
Mar 25, 2026
Merged

Fix Kafka integration test SASL configuration #796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions build/test/compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,15 @@ services:
test-kafka:
image: confluentinc/confluent-local:7.4.0
environment:
- KAFKA_ADVERTISED_LISTENERS=PLAINTEXT://test-kafka:29092,PLAINTEXT_HOST://localhost:39092
- KAFKA_LISTENERS=PLAINTEXT://0.0.0.0:29092,CONTROLLER://localhost:29093,PLAINTEXT_HOST://0.0.0.0:9092
KAFKA_ADVERTISED_LISTENERS: SASL_PLAINTEXT://test-kafka:29092,SASL_PLAINTEXT_HOST://localhost:39092
KAFKA_LISTENERS: SASL_PLAINTEXT://0.0.0.0:29092,CONTROLLER://localhost:29093,SASL_PLAINTEXT_HOST://0.0.0.0:9092
KAFKA_LISTENER_SECURITY_PROTOCOL_MAP: SASL_PLAINTEXT:SASL_PLAINTEXT,SASL_PLAINTEXT_HOST:SASL_PLAINTEXT,CONTROLLER:PLAINTEXT
KAFKA_INTER_BROKER_LISTENER_NAME: SASL_PLAINTEXT
KAFKA_SASL_MECHANISM_INTER_BROKER_PROTOCOL: PLAIN
KAFKA_SASL_ENABLED_MECHANISMS: PLAIN
KAFKA_OPTS: "-Djava.security.auth.login.config=/etc/kafka/jaas.conf"
volumes:
- ./kafka_jaas.conf:/etc/kafka/jaas.conf:ro
ports:
- 39092:9092
test-gcp:
Expand Down
6 changes: 6 additions & 0 deletions build/test/kafka_jaas.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
KafkaServer {
org.apache.kafka.common.security.plain.PlainLoginModule required
username="admin"
password="admin-secret"
user_admin="admin-secret";
};
16 changes: 13 additions & 3 deletions internal/destregistry/providers/destkafka/destkafka_publish_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import (
"github.com/hookdeck/outpost/internal/util/testinfra"
"github.com/hookdeck/outpost/internal/util/testutil"
"github.com/segmentio/kafka-go"
"github.com/segmentio/kafka-go/sasl/plain"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"github.com/stretchr/testify/suite"
Expand All @@ -29,9 +30,15 @@ type KafkaConsumer struct {
}

func NewKafkaConsumer(brokerAddr, topic string) (*KafkaConsumer, error) {
mechanism := plain.Mechanism{Username: "admin", Password: "admin-secret"}
dialer := &kafka.Dialer{
SASLMechanism: mechanism,
Timeout: 10 * time.Second,
}
reader := kafka.NewReader(kafka.ReaderConfig{
Brokers: []string{brokerAddr},
Topic: topic,
Dialer: dialer,
StartOffset: kafka.FirstOffset,
MaxWait: 500 * time.Millisecond,
})
Expand Down Expand Up @@ -143,8 +150,8 @@ func (s *KafkaPublishSuite) SetupSuite() {
"sasl_mechanism": "plain",
}),
testutil.DestinationFactory.WithCredentials(map[string]string{
"username": "user",
"password": "pass",
"username": "admin",
"password": "admin-secret",
}),
)

Expand Down Expand Up @@ -242,7 +249,10 @@ func TestKafkaPublisher_ConnectionErrors(t *testing.T) {
func ensureKafkaTopic(t *testing.T, brokerAddr, topic string) {
t.Helper()

conn, err := kafka.Dial("tcp", brokerAddr)
mechanism := plain.Mechanism{Username: "admin", Password: "admin-secret"}
dialer := &kafka.Dialer{SASLMechanism: mechanism, Timeout: 10 * time.Second}

conn, err := dialer.DialContext(context.Background(), "tcp", brokerAddr)
require.NoError(t, err)
defer conn.Close()

Expand Down
17 changes: 12 additions & 5 deletions internal/util/testinfra/kafka.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,22 @@ func startKafkaTestContainer(cfg *Config) {
// maps to a random port but the broker advertises 9092, clients would fail.
const hostPort = "19092"

jaasConfig := `org.apache.kafka.common.security.plain.PlainLoginModule required username="admin" password="admin-secret" user_admin="admin-secret";`

req := testcontainers.ContainerRequest{
Image: "confluentinc/confluent-local:7.4.0",
ExposedPorts: []string{hostPort + ":9092/tcp"},
Env: map[string]string{
"KAFKA_ADVERTISED_LISTENERS": "PLAINTEXT://localhost:29092,PLAINTEXT_HOST://localhost:" + hostPort,
"KAFKA_LISTENER_SECURITY_PROTOCOL_MAP": "PLAINTEXT:PLAINTEXT,PLAINTEXT_HOST:PLAINTEXT,CONTROLLER:PLAINTEXT",
"KAFKA_LISTENERS": "PLAINTEXT://0.0.0.0:29092,PLAINTEXT_HOST://0.0.0.0:9092,CONTROLLER://0.0.0.0:9093",
"KAFKA_INTER_BROKER_LISTENER_NAME": "PLAINTEXT",
"KAFKA_CONTROLLER_LISTENER_NAMES": "CONTROLLER",
"KAFKA_ADVERTISED_LISTENERS": "SASL_PLAINTEXT://localhost:29092,SASL_PLAINTEXT_HOST://localhost:" + hostPort,
"KAFKA_LISTENER_SECURITY_PROTOCOL_MAP": "SASL_PLAINTEXT:SASL_PLAINTEXT,SASL_PLAINTEXT_HOST:SASL_PLAINTEXT,CONTROLLER:PLAINTEXT",
"KAFKA_LISTENERS": "SASL_PLAINTEXT://0.0.0.0:29092,SASL_PLAINTEXT_HOST://0.0.0.0:9092,CONTROLLER://0.0.0.0:9093",
"KAFKA_INTER_BROKER_LISTENER_NAME": "SASL_PLAINTEXT",
"KAFKA_CONTROLLER_LISTENER_NAMES": "CONTROLLER",
"KAFKA_SASL_MECHANISM_INTER_BROKER_PROTOCOL": "PLAIN",
"KAFKA_SASL_ENABLED_MECHANISMS": "PLAIN",
"KAFKA_LISTENER_NAME_SASL__PLAINTEXT_PLAIN_SASL_JAAS_CONFIG": jaasConfig,
"KAFKA_LISTENER_NAME_SASL__PLAINTEXT__HOST_PLAIN_SASL_JAAS_CONFIG": jaasConfig,
"KAFKA_OPTS": "-Djava.security.auth.login.config=/dev/null",
"KAFKA_OFFSETS_TOPIC_REPLICATION_FACTOR": "1",
"KAFKA_TRANSACTION_STATE_LOG_MIN_ISR": "1",
"KAFKA_TRANSACTION_STATE_LOG_REPLICATION_FACTOR": "1",
Expand Down
Loading