fix: scope Redis control plane keys by deployment ID#742
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Control plane keys (installation ID, migration lock, migration status)
were not prefixed with DEPLOYMENT_ID, causing collisions when multiple
deployments share the same Redis instance.
Key renames:
- outpostrc (hash) → outpost:installation_id (string)
- .outpost:migration:lock → .outpost:migration_lock
- outpost:migration:{name} → unchanged (now prefixed when scoped)
All keys are prefixed with {deploymentID}: when DEPLOYMENT_ID is set,
matching the existing pattern used by tenant store, alert store, etc.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
DUMP/RESTORE fails silently on Dragonfly (and potentially other Redis alternatives) because bash command substitution strips null bytes from the binary payload. Replace with field-by-field HGETALL read loop and HSET, plus a post-copy verification check. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
alexluong
force-pushed
the
fix/680-scope-control-plane-keys
branch
from
a38bc6d to
e05118f
Compare
KEYS blocks Redis single-threaded event loop while scanning the entire keyspace. Since checkIfFreshInstallation only needs to know if at least one matching key exists, use SCAN with COUNT 1 for a non-blocking check. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
alexbouchardd
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #680
Control plane keys (
outpostrc,.outpost:migration:lock,outpost:migration:*) were not prefixed withDEPLOYMENT_ID, causing collisions when multiple deployments share the same Redis instance.outpostrc(hash) →outpost:installation_id(string), prefixed with{deploymentID}:when set.outpost:migration:lock→.outpost:migration_lock, prefixed with{deploymentID}:when setoutpost:migration:{name}status keys with{deploymentID}:when setIncludes
scripts/issue-680/with a data migration script and manual QA test cases.TODO
scripts/issue-680/TEST_CASES.md)🤖 Generated with Claude Code