Skip to content

perf: improve body read performance #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
usualoma wants to merge 1 commit into
base: pref/request-v2
Choose a base branch
from
+899 −77
Open

perf: improve body read performance #311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions src/listener.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import type { Http2ServerResponse } from 'node:http2'
import type { Writable } from 'node:stream'
import type { IncomingMessageWithWrapBodyStream } from './request'
import {
abortControllerKey,
abortRequest,
newRequest,
Request as LightweightRequest,
wrapBodyStream,
Expand Down Expand Up @@ -260,13 +260,14 @@ export const getRequestListener = (

// Detect if request was aborted.
outgoing.on('close', () => {
const abortController = req[abortControllerKey] as AbortController | undefined
if (abortController) {
if (incoming.errored) {
req[abortControllerKey].abort(incoming.errored.toString())
} else if (!outgoing.writableFinished) {
req[abortControllerKey].abort('Client connection prematurely closed.')
}
let abortReason: string | undefined
if (incoming.errored) {
abortReason = incoming.errored.toString()
} else if (!outgoing.writableFinished) {
abortReason = 'Client connection prematurely closed.'
}
if (abortReason !== undefined) {
req[abortRequest](abortReason)
}

// incoming is not consumed to the end
Expand Down
Loading