-
Notifications
You must be signed in to change notification settings - Fork 413
Add experimental options to display iOS UI going edge to edge #4279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated WebViewController to apply edge-to-edge layout when either edge-to-edge or fullScreen mode is enabled, and improved statusBarView background color handling by using a stored reference. Also ensured layout and styling are refreshed when toggling these modes. Minor formatting adjustment in GeneralSettingsView.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds an experimental "edge to edge display" feature that allows the Home Assistant iOS UI to extend to the screen edges on supported devices. The feature is configurable via a new toggle in the General Settings and affects how the WebView is positioned relative to the status bar.
Changes:
- Added a new
edgeToEdgesetting to SettingsStore with notification support for UI updates - Modified WebViewController to dynamically adjust WebView constraints and status bar visibility based on the edge-to-edge setting
- Added a new "Experimental" section in GeneralSettingsView with a toggle for the edge-to-edge display option
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| Sources/Shared/Settings/SettingsStore.swift | Adds the edgeToEdge boolean property with persistence and change notifications |
| Sources/App/WebView/WebViewController.swift | Implements dynamic layout constraint management to support edge-to-edge display, including hiding/showing status bar and adjusting WebView positioning |
| Sources/App/Settings/General/GeneralSettingsView.swift | Adds UI toggle in an "Experimental" section to control the edge-to-edge display feature |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4279 +/- ##
=======================================
Coverage ? 43.13%
=======================================
Files ? 261
Lines ? 15084
Branches ? 0
=======================================
Hits ? 6506
Misses ? 8578
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Summary
Screenshots
Screen.Recording.2026-01-29.at.17.40.46.mov
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes