Skip to content

Conversation

@bgoncal
Copy link
Member

@bgoncal bgoncal commented Jan 29, 2026

Summary

Screenshots

Screen.Recording.2026-01-29.at.17.40.46.mov

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

Updated WebViewController to apply edge-to-edge layout when either edge-to-edge or fullScreen mode is enabled, and improved statusBarView background color handling by using a stored reference. Also ensured layout and styling are refreshed when toggling these modes. Minor formatting adjustment in GeneralSettingsView.
@bgoncal bgoncal self-assigned this Jan 29, 2026
Copilot AI review requested due to automatic review settings January 29, 2026 16:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds an experimental "edge to edge display" feature that allows the Home Assistant iOS UI to extend to the screen edges on supported devices. The feature is configurable via a new toggle in the General Settings and affects how the WebView is positioned relative to the status bar.

Changes:

  • Added a new edgeToEdge setting to SettingsStore with notification support for UI updates
  • Modified WebViewController to dynamically adjust WebView constraints and status bar visibility based on the edge-to-edge setting
  • Added a new "Experimental" section in GeneralSettingsView with a toggle for the edge-to-edge display option

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
Sources/Shared/Settings/SettingsStore.swift Adds the edgeToEdge boolean property with persistence and change notifications
Sources/App/WebView/WebViewController.swift Implements dynamic layout constraint management to support edge-to-edge display, including hiding/showing status bar and adjusting WebView positioning
Sources/App/Settings/General/GeneralSettingsView.swift Adds UI toggle in an "Experimental" section to control the edge-to-edge display feature

@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@6b2f83e). Learn more about missing BASE report.

Files with missing lines Patch % Lines
Sources/Shared/Settings/SettingsStore.swift 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4279   +/-   ##
=======================================
  Coverage        ?   43.13%           
=======================================
  Files           ?      261           
  Lines           ?    15084           
  Branches        ?        0           
=======================================
  Hits            ?     6506           
  Misses          ?     8578           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@bgoncal bgoncal merged commit daa4a05 into main Jan 29, 2026
15 checks passed
@bgoncal bgoncal deleted the edge-to-edge-2 branch January 29, 2026 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants