-
Notifications
You must be signed in to change notification settings - Fork 213
feat(dbml/connector): add sqlite and oracle connectors #748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| if (columnsWithEnum[key]) { | ||
| actualType = { | ||
| type_name: columnsWithEnum[key].name, | ||
| schemaName: 'main', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the default SCHEMA_NAME = 'main' and define a method to get full table name, for example:
const getFullTableName = (tbName) => `${SCHEMA_NAME}.${tbName}`;Then, you can use the getFullTableName method in your maps below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you want getFullColumnName right? So that the columnsWithEnum's key can be generated by the same function
|
You also need to add cli support for |
|
@HungKNguyen Can you change the head of your fork to a branch that I can commit. It is https://github.com/PSPDFKit-labs/dbml/tree/master now. |
@nguyenalter I had to open another PR to change the base branch #750 |
Summary
sqliteandoracleto the supported database for@dbml/connectorIssue
(issue link here)
Lasting Changes (Technical)
(please list down: code changes/things that have wide-effect; new libraries/functions added that can be used by others; examples below)
class EmailValidatorto validate email address' validity)Tenant#is_trial?check)Checklist
Please check directly on the box once each of these are done