Skip to content

Conversation

@HungKNguyen
Copy link

Summary

  • Added sqlite and oracle to the supported database for @dbml/connector

Issue

(issue link here)

Lasting Changes (Technical)

(please list down: code changes/things that have wide-effect; new libraries/functions added that can be used by others; examples below)

  • (Added class EmailValidator to validate email address' validity)
  • (Added Tenant#is_trial? check)

Checklist

Please check directly on the box once each of these are done

  • Documentation (if necessary)
  • Tests (integration test/unit test)
  • Integration Tests Passed
  • Code Review

if (columnsWithEnum[key]) {
actualType = {
type_name: columnsWithEnum[key].name,
schemaName: 'main',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the default SCHEMA_NAME = 'main' and define a method to get full table name, for example:

const getFullTableName = (tbName) => `${SCHEMA_NAME}.${tbName}`;

Then, you can use the getFullTableName method in your maps below

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you want getFullColumnName right? So that the columnsWithEnum's key can be generated by the same function

@nguyenalter
Copy link
Contributor

You also need to add cli support for db2dbml oracle <connection> command. You can follow my sample commit (2a6e73c)

@HungKNguyen HungKNguyen requested a review from nguyenalter August 7, 2025 02:54
@nguyenalter
Copy link
Contributor

@HungKNguyen Can you change the head of your fork to a branch that I can commit. It is https://github.com/PSPDFKit-labs/dbml/tree/master now.
I want to add test and update CI for oracle connector.

@HungKNguyen
Copy link
Author

@HungKNguyen Can you change the head of your fork to a branch that I can commit. It is https://github.com/PSPDFKit-labs/dbml/tree/master now.
I want to add test and update CI for oracle connector.

@nguyenalter I had to open another PR to change the base branch #750

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants