Skip to content

fix: include dummy-node in helper functions #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
H-DNA wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: include dummy-node in helper functions #642

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
759f466
fix: include dummy-node in markInvalidNode
H-DNA Sep 23, 2024
198aaf1
fix: include DummyNode in getMemberChain
H-DNA Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/dbml-parse/src/lib/parser/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import {
AttributeNode,
BlockExpressionNode,
CallExpressionNode,
DummyNode,
ElementDeclarationNode,
ExpressionNode,
FunctionApplicationNode,
Expand Down Expand Up @@ -167,7 +168,7 @@ function markInvalidNode(node: SyntaxNode) {
markInvalid(node.literal);
} else if (node instanceof GroupExpressionNode) {
throw new Error('This case is handled by the TupleExpressionNode case');
} else {
} else if (!(node instanceof DummyNode)) {
throw new Error('Unreachable case in markInvalidNode');
}
}
Expand Down Expand Up @@ -270,10 +271,15 @@ export function getMemberChain(node: SyntaxNode): Readonly<(SyntaxNode | SyntaxT
)
}

if (node instanceof DummyNode) {
return [];
}

if (node instanceof GroupExpressionNode) {
throw new Error('This case is already handled by TupleExpressionNode');
}


throw new Error('Unreachable - no other possible cases');
}

Expand Down