Slight Faster Softdrop for better control #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this pr changes how fast the blocks drop down. I expected the blocks to drop faster I watched the blocks drop faster. I would add screenshots of the code you changed so your request has a higher chance to be approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the softdrop by the block going down about double the speed.
This matters because the original softdrop was more slower, took time to go through levels at a reasonable pace, and when you would want to drop the block, it would take more effort than needed to try and not also more the next block, so the block was hard to have control over.
I verified this by working the live preview and playing for a bit and compared it to the original to see if the control was better and if there was better control. I expected a more controllable block than before and more of a faster game play. I observed that when I pressed the down button it went down by three steps instead of one.
This PR is ready for review. Next Step would maybe be, where the user will be able to choose at what pace the block goes ( How many lines the block goes down), at their own liking.