Feat/custom fields hive #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simple solution to select the right value for select and tick the column header if all values matched :)
Co-authored-by: Harry Bragg <h.bragg+dev@gmail.com>
Auto Select values (Column with select fields)
Automatch select values
Fix mobile viewport size calculation
* add customFieldsHook into RsiProps: Runs on Match Columns step for each column when their state did change. Used to define custom fields with keys that are can be generated only from csv column header. * implement customFieldsHook logic * add dropDownLabel into Field - UI-facing label for dropdown option
* hive: feat/navigation (#1) # Conflicts: # src/steps/MatchColumnsStep/MatchColumnsStep.tsx # src/steps/UploadFlow.tsx # src/steps/ValidationStep/ValidationStep.tsx
- revert MatchIcon changes - more generic example of custom fields - mergeCustomFields - add custom fields to end of fields array
- revert MatchIcon changes - more generic example of custom fields - mergeCustomFields - add custom fields to end of fields array
…hive * feat/custom-fields-ugn-master: feat/custom-fields-hive - revert MatchIcon changes - more generic example of custom fields - mergeCustomFields - add custom fields to end of fields array # Conflicts: # src/steps/MatchColumnsStep/utils/customFields.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/hiveteams/Hive/pull/19410
https://github.com/hiveteams/hive-web-components/pull/15
#2
UgnisSoftware#221