Dev3.0.15 generate external_videos.xml for playing on the fly #236
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Generate external_videos.xml for play it back on the fly.
See: bigbluebutton/bbb-playback#127
You need to directly modify the script
/usr/local/bigbluebutton/core/lib/recordandplayback/generators/events.rb and
/usr/local/bigbluebutton/core/scripts/publish/presentation.rb and
/usr/local/bigbluebutton/core/scripts/presentation.yml
This PR is necessary for hiroshisuga/bbb-playback#39 .
See also the never-merged PR bigbluebutton#18222 for description.
Closes Issue(s)
Closes #
Motivation
More
Still to do:
Since BBB3.0 using GraphQL, the event.xml items related to external video have been massively reduced.
For instance,
We need to recover or make some workaround in the record_and_playback module to make it fully working.
On the other hand, we may have new events implemented since 3.0 (probably only 'seek' event). Need a research.
The easiest option is to change the player:
https://github.com/hiroshisuga/bbb-playback/blob/abe1b59883de8f3a80b1deb5ac42d72aae4a6c2e/src/components/external-video-player/index.js#L237-L313