Hashmap 929#14
Open
hiroki-horiguchi-dev wants to merge 4 commits into
Open
Conversation
h-masder
reviewed
May 1, 2026
| - [ここ](https://github.com/Yoshiki-Iwasa/Arai60/pull/13#discussion_r1676820615)で議論されているようなユースケースかあ、うーんと思うなどした。 | ||
| - [ユースケースの想定2](https://github.com/syoshida20/leetcode/pull/20#discussion_r2079714768) | ||
| - データサイエンス目的の処理内で使われているバッチであれば落ちてほしい、なるほどそうかと思った | ||
| - [rfc3.4.1を読んでみるなどした](https://www.rfc-editor.org/rfc/rfc5322.html#section-3.4.1) |
There was a problem hiding this comment.
akmhmgc/arai60#11 (comment)
もしご覧になっていなければ、このあたりも見てもいいと思います。
こういった記事もあります。
https://www.regular-expressions.info/email.html
Owner
Author
There was a problem hiding this comment.
確認できてなかったです、ありがとうございます！
hiro111208
reviewed
May 3, 2026
| Set<String> uniqueEmails = new HashSet<>(); | ||
| for (String email : emails) { | ||
| // split at @ index. | ||
| String[] pair = email.split("@"); |
There was a problem hiding this comment.
pairだけだとややわかりにくいかもしれません。
例えばlocalAndDomainとすると、より変数の目的がわかりやすいと思います。
Owner
Author
There was a problem hiding this comment.
コメントありがとうございます、おっしゃる通り少し悩みました。
が、このくらいの変数のスコープであれば split を使っていることからも意図が明白だと思ったので pairにしてます。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
レビューお願いします！