Skip to content

Add comprehensive test coverage for CSVDialog class #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
highperformancecoder merged 5 commits into from
Nov 18, 2025
Merged

Add comprehensive test coverage for CSVDialog class #582

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d555823
Initial plan
Copilot Nov 15, 2025
2df4f47
Add comprehensive tests for CSVDialog class methods
Copilot Nov 15, 2025
f42423c
Add edge case tests for CSVDialog class
Copilot Nov 15, 2025
ba40db9
Fix unit tests.
highperformancecoder Nov 18, 2025
92dadfb
CodeRabbit suggested fix
highperformancecoder Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions model/CSVDialog.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,11 +81,14 @@ void CSVDialog::loadFileFromName(const std::string& fname)
initialLines.clear();
for (size_t i=0; i<numInitialLines && is; ++i)
{
initialLines.emplace_back();
getline(is, initialLines.back());
// chomp any final '\r' character (DOS files)
if (!initialLines.back().empty() && initialLines.back().back()=='\r')
initialLines.back().erase(initialLines.back().end()-1);
string buf;
if (getline(is, buf))
{
initialLines.emplace_back(std::move(buf));
// chomp any final '\r' character (DOS files)
if (!initialLines.back().empty() && initialLines.back().back()=='\r')
initialLines.back().erase(initialLines.back().end()-1);
}
}
// Ensure dimensions.size() is the same as nColAxes() upon first load of a CSV file. For ticket 974.
if (spec.dimensions.size()<spec.nColAxes()) spec.setDataArea(spec.nRowAxes(),spec.nColAxes());
Expand Down
Loading
Loading