added findVariable method to pyminsky class, updated findObject to guarante ... #533
Conversation
…e stability and refactored tests using findVariable
wdednam
left a comment
wdednam
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @wdednam)
| auto& canvas = minsky.canvas; | ||
|
|
||
| canvas.item.reset(); | ||
| canvas.item.reset(); // Reset the item to ensure no leftover references |
There was a problem hiding this comment.
indentation has gone a bit weird
There was a problem hiding this comment.
Oops. I must have accidentally pressed the tab key on that line. I'll check the indentation more carefully prior to a pull request next time.
| canvas.item = canvas.model->groups.front(); | ||
| else | ||
| minsky.model->recursiveDo(&GroupItems::items, [&](const Items&, Items::const_iterator i) | ||
| bool found = false; |
There was a problem hiding this comment.
This found flag is redundant. It just shadows the validity status of canvas.item
There was a problem hiding this comment.
Understood. I was getting a segfault in the renameVariables.sh test, so I used it for added safety.
| return false; | ||
| }); | ||
|
|
||
| if (!found || !canvas.item) |
There was a problem hiding this comment.
found flag redundant here too.
highperformancecoder
merged commit 51a10f8
into
highperformancecoder:master
2 participants
…e stability, and refactored tests that call findVariable.
This change is