-
Notifications
You must be signed in to change notification settings - Fork 144
chore: removed old transport security comments #1208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: removed old transport security comments #1208
Conversation
Signed-off-by: Your Name <suyash1567@gmail.com>
CHANGELOG.md
Outdated
| - Add Linked Issue Enforcer to automatically close PRs without linked issues `.github/workflows/bot-linked-issue-enforcer.yml`. | ||
|
|
||
| ### Changed | ||
| - Removed old comments from `custom_fee_fixed.py` (#1153) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a little too generic, could you be more specific?
exploreriii
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great! please mark 'ready to review' once you think its ready to be reviewed! will happy take a look
Thanks again
|
Hi @suyash1567 One easy approach is to soft revert the last commit and recommit crrectly git reset --soft HEAD~1 I notice you also now have some merge conflicts, because we have updated the python sdk. Thank you |
|
@suyash1567 , Thanks for your contribution! Attached is a link to our SIGNING.md Please let us know if you need any further assistance, we are happy to help! |
|
Hi, this is MergeConflictBot. Please resolve these conflicts locally and push the changes. To assist you, please read: Thank you for contributing! |
|
Hi @suyash1567, This pull request has had no commit activity for 10 days. Are you still working on the issue? please push a commit to keep the PR active or it will be closed due to inactivity. From the Python SDK Team |
|
Closing as inactive, please do see if there are any other issues that interest you |
Description:Removing old transport security comments examples/tokens/custom_fee_fixed.py
Related issue(s):
Fixes #1153
Notes for reviewer:
Checklist