Skip to content

Conversation

@suyash1567
Copy link
Contributor

Description:Removing old transport security comments examples/tokens/custom_fee_fixed.py

Related issue(s):

Fixes #1153

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Your Name <suyash1567@gmail.com>
CHANGELOG.md Outdated
- Add Linked Issue Enforcer to automatically close PRs without linked issues `.github/workflows/bot-linked-issue-enforcer.yml`.

### Changed
- Removed old comments from `custom_fee_fixed.py` (#1153)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a little too generic, could you be more specific?

Copy link
Contributor

@exploreriii exploreriii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! please mark 'ready to review' once you think its ready to be reviewed! will happy take a look

Thanks again

@exploreriii
Copy link
Contributor

Hi @suyash1567
Apologies for the delay.
I note that some of your commits are not signed correctly - take a look at:
https://github.com/hiero-ledger/hiero-sdk-python/pull/1208/checks?check_run_id=58811559271

One easy approach is to soft revert the last commit and recommit crrectly

git reset --soft HEAD~1
git commit -S -s -m "chore: move changelog entry"

I notice you also now have some merge conflicts, because we have updated the python sdk.
I think you'll just have to accept both changes in the online editor to pass that.

Thank you

@aceppaluni
Copy link
Contributor

@suyash1567 , Thanks for your contribution!

Attached is a link to our SIGNING.md

Please let us know if you need any further assistance, we are happy to help!

@github-actions
Copy link

Hi, this is MergeConflictBot.
Your pull request cannot be merged because it contains merge conflicts.

Please resolve these conflicts locally and push the changes.

To assist you, please read:

Thank you for contributing!

@github-actions
Copy link

github-actions bot commented Jan 3, 2026

Hi @suyash1567,

This pull request has had no commit activity for 10 days. Are you still working on the issue? please push a commit to keep the PR active or it will be closed due to inactivity.
Reach out on discord or join our office hours if you need assistance.

From the Python SDK Team

@exploreriii
Copy link
Contributor

Closing as inactive, please do see if there are any other issues that interest you

@exploreriii exploreriii closed this Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Good First Issue]: Remove old transport security comments in examples/tokens/custom_fee_fixed.py

3 participants