Skip to content

Conversation

@exploreriii
Copy link
Contributor

@exploreriii exploreriii commented Dec 11, 2025

Description:
Adds a github CODEOWNERS file which will auto-request reviews from certain parties

Related issue(s):
Fixes #526

Notes for reviewer:
I have used this as an example
https://github.com/hiero-ledger/solo/blob/main/.github/CODEOWNERS

I have mostly requested review from triage, committers and maintainers always, believing that it is good to be informed. Our triage members do not have write access.
Config files are mostly maintainers
However, am unsure about the desired level of spam

Summary by CodeRabbit

  • Chores
    • Introduced a centralized code ownership policy to clarify responsibility across core components, tests, examples, documentation, workflows, packaging, and tooling.
    • Added a changelog entry noting the new repository code ownership configuration to make the change discoverable for contributors and maintainers.

✏️ Tip: You can customize this high-level summary in your review settings.

@exploreriii exploreriii marked this pull request as ready for review December 11, 2025 22:07
@github-actions
Copy link

Hello, this is the Office Hour Bot.

This is a reminder that the Hiero Python SDK Office Hours are scheduled in approximately 4 hours (14:00 UTC).

This session provides an opportunity to ask questions regarding this Pull Request or receive assistance from a maintainer.

Details:

Disclaimer: This is an automated reminder. Please verify the schedule here to be notified of any changes.

Signed-off-by: exploreriii <133720349+exploreriii@users.noreply.github.com>
Signed-off-by: exploreriii <133720349+exploreriii@users.noreply.github.com>
Signed-off-by: exploreriii <133720349+exploreriii@users.noreply.github.com>
Signed-off-by: exploreriii <133720349+exploreriii@users.noreply.github.com>
Signed-off-by: exploreriii <133720349+exploreriii@users.noreply.github.com>
@coderabbitai
Copy link

coderabbitai bot commented Dec 20, 2025

Walkthrough

Adds a new .github/CODEOWNERS file that centralizes code ownership and protection rules for repository areas (core, tests, examples, docs, workflows, packaging, tooling), and updates CHANGELOG.md to record the addition.

Changes

Cohort / File(s) Summary
GitHub configuration
​.github/CODEOWNERS
New CODEOWNERS file defining ownership and protection rules across repository sections (core files, src, tests, examples, docs, workflows, packaging/build, tooling, and config files) with global and path-specific entries.
Changelog
CHANGELOG.md
Updated Unreleased > Added section to include the new "Github CODEOWNERS" entry.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify CODEOWNERS syntax and ordering match GitHub requirements (specificity, precedence).
  • Confirm referenced paths (e.g., src/, tests/, .github/workflows/, docs/examples) correctly reflect repository layout.
  • Validate that listed owner handles/teams are valid within the org and follow required format.
  • Check changelog entry formatting and placement.

Poem

🐰 I hopped along the tree of code tonight,
I placed a sign to show who keeps it right.
From tests to docs and every hidden file,
I've marked the paths — and left a tiny smile. 🥕

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title 'ci: add github codeowners' is concise and clearly describes the main change—adding a GitHub CODEOWNERS file.
Linked Issues check ✅ Passed The PR successfully implements the objective from issue #526 by introducing a valid .github/CODEOWNERS file with appropriate ownership assignments.
Out of Scope Changes check ✅ Passed All changes are directly related to adding and documenting the CODEOWNERS file; no out-of-scope changes detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Dec 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1049   +/-   ##
=======================================
  Coverage   91.26%   91.26%           
=======================================
  Files         139      139           
  Lines        8447     8447           
=======================================
  Hits         7709     7709           
  Misses        738      738           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: exploreriii <133720349+exploreriii@users.noreply.github.com>
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4f33085 and ea4f5ed.

📒 Files selected for processing (2)
  • .github/CODEOWNERS (1 hunks)
  • CHANGELOG.md (1 hunks)
🧰 Additional context used
🪛 LanguageTool
CHANGELOG.md

[uncategorized] ~24-~24: The official name of this software platform is spelled with a capital “H”.
Context: ...thors when reviewers request changes. - Github CODEOWNERS - Modularized `transfer_tran...

(GITHUB)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
  • GitHub Check: Codacy Static Code Analysis
  • GitHub Check: run-examples
  • GitHub Check: build-and-test (3.12)
  • GitHub Check: build-and-test (3.13)
  • GitHub Check: build-and-test (3.10)
  • GitHub Check: build-and-test (3.11)
  • GitHub Check: StepSecurity Harden-Runner
🔇 Additional comments (2)
.github/CODEOWNERS (2)

1-54: CODEOWNERS structure and assignment logic look good.

The two-tier approach is well-designed:

  • Project files (lines 5, 13-23): Assigned to triage, committers, and maintainers—keeps the full team informed while enabling collaborative review.
  • Core files (lines 31-54): Restricted to maintainers—protects critical configuration, workflows, packaging, and governance files from unintended changes.

The file structure is clear with descriptive section headers, and the self-protection rules (line 46) follow best practices. The ordering enables specific rules to override the catch-all, which is the correct CODEOWNERS precedence.


5-5: CODEOWNERS file is correctly configured with valid team references.

The file uses proper syntax for all team assignments following the @org/team-name format. The three referenced teams (python-triage, python-committers, python-maintainers) are consistently assigned across project files, tests, documentation, and core configuration areas. GitHub automatically validates team existence and permissions during pull request review, so the configuration requirements are met.

@exploreriii
Copy link
Contributor Author

Request review @nadineloepfe @manishdait CODEOWNERS

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🧹 Nitpick comments (1)
.github/CODEOWNERS (1)

48-55: Optional: Improve readability with consistent whitespace alignment.

The file uses inconsistent spacing for alignment (e.g., compare lines 49 vs. 50, or comments on lines 44 vs. 48). Standardizing to a fixed-width column for team assignments (e.g., column 60 or 65) would improve scanability and reduce merge conflicts when adding rules.

Minor note: Line 50 (LICENSE) correctly includes both python-maintainers and the TSC group, reflecting the legal/governance nature of that file. Consider whether other files (e.g., CHANGELOG.md, tox.ini) warrant explicit rules to clarify review expectations.

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ea4f5ed and 123aa71.

📒 Files selected for processing (1)
  • .github/CODEOWNERS (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
  • GitHub Check: Codacy Static Code Analysis
  • GitHub Check: build-and-test (3.10)
  • GitHub Check: build-and-test (3.12)
  • GitHub Check: build-and-test (3.13)
  • GitHub Check: build-and-test (3.11)
  • GitHub Check: run-examples
  • GitHub Check: StepSecurity Harden-Runner

@manishdait
Copy link
Contributor

Would like to have second review from the @nadineloepfe

@github-actions
Copy link

Hi @exploreriii,

This pull request has had no commit activity for 10 days. Are you still working on the issue? please push a commit to keep the PR active or it will be closed due to inactivity.
Reach out on discord or join our office hours if you need assistance.

From the Python SDK Team

@github-actions
Copy link

Hi, this is MergeConflictBot.
Your pull request cannot be merged because it contains merge conflicts.

Please resolve these conflicts locally and push the changes.

To assist you, please read:

Thank you for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add github CODEOWNERS file

3 participants