-
Notifications
You must be signed in to change notification settings - Fork 142
ci: add github codeowners #1049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
475f1b5 to
fafa046
Compare
|
Hello, this is the Office Hour Bot. This is a reminder that the Hiero Python SDK Office Hours are scheduled in approximately 4 hours (14:00 UTC). This session provides an opportunity to ask questions regarding this Pull Request or receive assistance from a maintainer. Details:
Disclaimer: This is an automated reminder. Please verify the schedule here to be notified of any changes. |
Signed-off-by: exploreriii <133720349+exploreriii@users.noreply.github.com>
Signed-off-by: exploreriii <133720349+exploreriii@users.noreply.github.com>
Signed-off-by: exploreriii <133720349+exploreriii@users.noreply.github.com>
Signed-off-by: exploreriii <133720349+exploreriii@users.noreply.github.com>
Signed-off-by: exploreriii <133720349+exploreriii@users.noreply.github.com>
fafa046 to
ea4f5ed
Compare
WalkthroughAdds a new Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1049 +/- ##
=======================================
Coverage 91.26% 91.26%
=======================================
Files 139 139
Lines 8447 8447
=======================================
Hits 7709 7709
Misses 738 738 🚀 New features to boost your workflow:
|
Signed-off-by: exploreriii <133720349+exploreriii@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/CODEOWNERS(1 hunks)CHANGELOG.md(1 hunks)
🧰 Additional context used
🪛 LanguageTool
CHANGELOG.md
[uncategorized] ~24-~24: The official name of this software platform is spelled with a capital “H”.
Context: ...thors when reviewers request changes. - Github CODEOWNERS - Modularized `transfer_tran...
(GITHUB)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: run-examples
- GitHub Check: build-and-test (3.12)
- GitHub Check: build-and-test (3.13)
- GitHub Check: build-and-test (3.10)
- GitHub Check: build-and-test (3.11)
- GitHub Check: StepSecurity Harden-Runner
🔇 Additional comments (2)
.github/CODEOWNERS (2)
1-54: CODEOWNERS structure and assignment logic look good.The two-tier approach is well-designed:
- Project files (lines 5, 13-23): Assigned to triage, committers, and maintainers—keeps the full team informed while enabling collaborative review.
- Core files (lines 31-54): Restricted to maintainers—protects critical configuration, workflows, packaging, and governance files from unintended changes.
The file structure is clear with descriptive section headers, and the self-protection rules (line 46) follow best practices. The ordering enables specific rules to override the catch-all, which is the correct CODEOWNERS precedence.
5-5: CODEOWNERS file is correctly configured with valid team references.The file uses proper syntax for all team assignments following the @org/team-name format. The three referenced teams (python-triage, python-committers, python-maintainers) are consistently assigned across project files, tests, documentation, and core configuration areas. GitHub automatically validates team existence and permissions during pull request review, so the configuration requirements are met.
|
Request review @nadineloepfe @manishdait CODEOWNERS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
🧹 Nitpick comments (1)
.github/CODEOWNERS (1)
48-55: Optional: Improve readability with consistent whitespace alignment.The file uses inconsistent spacing for alignment (e.g., compare lines 49 vs. 50, or comments on lines 44 vs. 48). Standardizing to a fixed-width column for team assignments (e.g., column 60 or 65) would improve scanability and reduce merge conflicts when adding rules.
Minor note: Line 50 (LICENSE) correctly includes both
python-maintainersand the TSC group, reflecting the legal/governance nature of that file. Consider whether other files (e.g., CHANGELOG.md, tox.ini) warrant explicit rules to clarify review expectations.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/CODEOWNERS(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: build-and-test (3.10)
- GitHub Check: build-and-test (3.12)
- GitHub Check: build-and-test (3.13)
- GitHub Check: build-and-test (3.11)
- GitHub Check: run-examples
- GitHub Check: StepSecurity Harden-Runner
|
Would like to have second review from the @nadineloepfe |
|
Hi @exploreriii, This pull request has had no commit activity for 10 days. Are you still working on the issue? please push a commit to keep the PR active or it will be closed due to inactivity. From the Python SDK Team |
|
Hi, this is MergeConflictBot. Please resolve these conflicts locally and push the changes. To assist you, please read: Thank you for contributing! |
Description:
Adds a github CODEOWNERS file which will auto-request reviews from certain parties
Related issue(s):
Fixes #526
Notes for reviewer:
I have used this as an example
https://github.com/hiero-ledger/solo/blob/main/.github/CODEOWNERS
I have mostly requested review from triage, committers and maintainers always, believing that it is good to be informed. Our triage members do not have write access.
Config files are mostly maintainers
However, am unsure about the desired level of spam
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.