Skip to content

fix(useMediaQuery): initial state on first render is wrong #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sapkra wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(useMediaQuery): initial state on first render is wrong #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions packages/core/useMediaQuery/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { useEffect, useState } from 'react'

import { useMount } from '../useMount'
import { isClient } from '@react-hooks-library/shared'

/**
* Reactive media query hook that returns the truthy value of the media query.
Expand All @@ -11,11 +10,11 @@ import { useMount } from '../useMount'
* @see https://react-hooks-library.vercel.app/core/useMediaQuery
*/
export function useMediaQuery(query: string): boolean {
const [matches, setMatches] = useState(false)
const [matches, setMatches] = useState(isClient ? window.matchMedia(query).matches : false)

useMount(() => {
useEffect(() => {
setMatches(window.matchMedia(query).matches)
})
}, [])

useEffect(() => {
const mediaQuery = window.matchMedia(query)
Expand Down