Skip to content

Add Release published timestamp field to .proto #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericmj merged 1 commit into from
May 18, 2026
+249 −106
Merged

Add Release published timestamp field to .proto #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions proto/hex_pb_package.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ message Release {
optional bytes outer_checksum = 5;
// Indexes into Package.advisories for advisories affecting this release
repeated uint32 advisory_indexes = 6;
// Release published timestamp
optional Timestamp published_at = 7;
}

message RetirementStatus {
Expand Down Expand Up @@ -78,3 +80,10 @@ message Dependency {
// If set, the repository where the dependency is located
optional string repository = 5;
}

// Based on google.protobuf.Timestamp
// https://github.com/protocolbuffers/protobuf/blob/v3.15.8/src/google/protobuf/timestamp.proto#L136:L147
message Timestamp {
Copy link
Copy Markdown
Contributor Author

@elfenlaid elfenlaid May 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The exact same type lives in the neighbour file

hex_core/proto/hex_pb_names.proto

Lines 17 to 24 in 795c08e

optional Timestamp updated_at = 3;
}
// Based on google.protobuf.Timestamp
// https://github.com/protocolbuffers/protobuf/blob/v3.15.8/src/google/protobuf/timestamp.proto#L136:L147
message Timestamp {
required int64 seconds = 1;
required int32 nanos = 2;

Yet, I've decided against sharing this type as I think it would be easier to replace it with a native protobuf Timestamp available in the third version of protobuf.

required int64 seconds = 1;
required int32 nanos = 2;
}
Loading
Loading