Fix double borrow of task when delivering user signals#241
Merged
hexagonal-sun merged 6 commits intohexagonal-sun:masterfrom Mar 2, 2026
Merged
Fix double borrow of task when delivering user signals#241hexagonal-sun merged 6 commits intohexagonal-sun:masterfrom
hexagonal-sun merged 6 commits intohexagonal-sun:masterfrom
Conversation
hexagonal-sun
approved these changes
Mar 1, 2026
Owner
hexagonal-sun
left a comment
There was a problem hiding this comment.
Nice catch!
I presume the segfault tests you've added to usertest tripped the double borrow?
Contributor
Author
|
Yeah - if you comment |
Owner
|
Merged. Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While experimenting with #237, I found a double borrow:
Borrowing current_task over the copy_to_user in do_signal causes a double borrow when run_mem_fault_handler runs (since the user stack is demand-paged)
It would be nice to have the type system help us here, but looks like
CurrentTaskGuardis already!Send+!Sync.