-
Notifications
You must be signed in to change notification settings - Fork 92
Revise Windows installation instructions for hcloud #1259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Updated installation instructions for hcloud on Windows to include winget.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1259 +/- ##
==========================================
- Coverage 72.50% 67.36% -5.14%
==========================================
Files 311 311
Lines 11431 11431
==========================================
- Hits 8288 7701 -587
- Misses 2211 2734 +523
- Partials 932 996 +64
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hey 👋 Thanks for your contribution 🙂 |
|
@phm07 Should we maybe add a note, that https://github.com/microsoft/winget-pkgs/blob/master/manifests/h/HetznerCloud/CLI is not maintained by us? cc @apricote |
Yes, please. |
Updated the Windows installation instructions for hcloud to use the full package name and added a note about package maintenance.
|
@phm07 Yes, the abbreviation works. However, I changed the PR to have the full name, just to make sure it does not change in the future. @lukasmetzner and @jooola I added a note that Hetzner does not maintain the winget package entry. |
| ``` | ||
|
|
||
| ### 1.4 Installation using scoop | ||
| ### 1.4 Installation in Windows using winget or scoop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ### 1.4 Installation in Windows using winget or scoop | |
| ### 1.4 Installation on Windows using winget or scoop |
| On Windows, you can install `hcloud` using winget (Windows Package Manager) or scoop: | ||
|
|
||
| ```bash | ||
| winget install HetznerCloud.CLI | ||
| ``` | ||
|
|
||
| ```bash | ||
| scoop install hcloud | ||
| ``` | ||
|
|
||
| > [!NOTE] | ||
| > The WinGet package entry is not maintained by Hetzner but points to the official releases in GitHub | ||
| > See: https://github.com/microsoft/winget-pkgs/tree/master/manifests/h/HetznerCloud/CLI | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| On Windows, you can install `hcloud` using winget (Windows Package Manager) or scoop: | |
| ```bash | |
| winget install HetznerCloud.CLI | |
| ``` | |
| ```bash | |
| scoop install hcloud | |
| ``` | |
| > [!NOTE] | |
| > The WinGet package entry is not maintained by Hetzner but points to the official releases in GitHub | |
| > See: https://github.com/microsoft/winget-pkgs/tree/master/manifests/h/HetznerCloud/CLI | |
| > [!WARNING] | |
| > The WinGet package entry is not maintained by Hetzner, but the maintainers point to our official releases on GitHub | |
| > See: https://github.com/microsoft/winget-pkgs/tree/master/manifests/h/HetznerCloud/CLI | |
| On Windows, you can install `hcloud` using winget (Windows Package Manager) or scoop: | |
| ```bash | |
| winget install HetznerCloud.CLI | |
| ``` | |
| ```bash | |
| scoop install hcloud | |
| ``` |
I would like to make this a warning and move it above the installation command. The user should read this carefully.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it would make sense to add that versions might be late or can be skipped entirely. Looking at the repo, for example v1.56.0 is missing: https://github.com/microsoft/winget-pkgs/tree/master/manifests/h/HetznerCloud/CLI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively we could release winget packages ourselves, like it was already requested: #958
Updated installation instructions for hcloud on Windows to include winget.