test: add acceptance tests for credential manager#316
Merged
erika-wallace merged 14 commits intofeat/credential-mgr-integrationfrom Mar 31, 2026
Merged
test: add acceptance tests for credential manager#316erika-wallace merged 14 commits intofeat/credential-mgr-integrationfrom
erika-wallace merged 14 commits intofeat/credential-mgr-integrationfrom
Conversation
k80bowman
requested changes
Mar 31, 2026
Contributor
k80bowman
left a comment
There was a problem hiding this comment.
Just a couple of small suggestions. Otherwise this looks amazing! Great work!
k80bowman
approved these changes
Mar 31, 2026
Contributor
k80bowman
left a comment
There was a problem hiding this comment.
Thank you for the updates! Looks great.
b6b65df
into
feat/credential-mgr-integration
13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds cross-platform acceptance test coverage for
heroku-credential-manager.libsecret-toolsandgnome-keyring.Notes:
listAccountsnow usesspawnSyncbecausesecret-tool search --allemitsattribute.accountinstderr(notstdout); unit tests were updated accordingly.hosts = []is used to avoid netrc writes and explicitly validate the native-store-only path.Bug Fixes:
listAccounts.$ErrorActionPreference = 'Stop'in Windows PowerShell commands to halt execution immediately.stderr.Type of Change
Breaking Changes (major semver update)
!after your change type to denote a change that breaks current behaviorFeature Additions (minor semver update)
Patch Updates (patch semver update)
Testing
Steps:
Screenshots (if applicable)
Related Issues
GUS work item: W-21745733