feat: leverage the heroku credential manager for auth#295
Open
michaelmalave wants to merge 5 commits intofeat/credential-mgr-integrationfrom
Open
feat: leverage the heroku credential manager for auth#295michaelmalave wants to merge 5 commits intofeat/credential-mgr-integrationfrom
michaelmalave wants to merge 5 commits intofeat/credential-mgr-integrationfrom
Conversation
…roku.auth work with async credential-manager
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@heroku/heroku-credential-manageras the single path for storing, reading, and removing Heroku CLI tokens.Type of Change
Breaking Changes (major semver update)
!after your change type to denote a change that breaks current behaviorFeature Additions (minor semver update)
Patch Updates (patch semver update)
Testing
Checkout this branch for heroku-cli-command.
Open the cli repo to the main branch. In the package.json, update your cli command dependency to:
run
npm install && npm run buildThen test with
and you should now see heroku-credential-manager logging as its being leveraged.
(note: expect debug lines from the credential manager (e.g. netrc load/save); Keychain usage is not always logged.)
Related Issues
GitHub issue: #[GitHub issue number]
GUS work item: W-20825872