feat: include a --no-wrap flag for table displays#3613
Open
heroku-johnny wants to merge 7 commits intomainfrom
Open
feat: include a --no-wrap flag for table displays#3613heroku-johnny wants to merge 7 commits intomainfrom
heroku-johnny wants to merge 7 commits intomainfrom
Conversation
--no-wrap flag for table displays
--no-wrap flag for table displaysMade-with: Cursor
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
--no-wrapflag toheroku domainsso domain table output can be copied/pasted without wrapped cell values.Default behavior is unchanged (
overflow: 'wrap'), and--no-wrapswitches table rendering to unbounded width for single-line values.Type of Change
Breaking Changes (major semver update)
!after your change type to denote a change that breaks current behaviorFeature Additions (minor semver update)
Patch Updates (patch semver update)
Testing
Notes:
Validated behavior manually against a real app with long DNS target values.
Steps:
npm run buildnode ./bin/run domains -a <app-name>(confirm default wrapped output remains)node ./bin/run domains -a <app-name> --no-wrap(confirm values remain on one line)node ./bin/run domains -a <app-name> | cat(reference output)npm run test:file -- test/unit/commands/domains/index.unit.test.tsScreenshots (if applicable)
Related Issues
GitHub issue: #3606
GUS work item: W-21715803
Notes / Follow-up
Other commands currently using
overflow: 'wrap'that may need the same--no-wrapoption for consistency:ps(src/commands/ps/index.ts)pg:credentials(src/commands/pg/credentials.ts)data:pg:credentials(src/commands/data/pg/credentials/index.ts)addons(src/commands/addons/index.ts)This Draft PR intentionally limits scope to
domainsonly.