Skip to content

Comments

Introduce ErrorCode::NoContent#1665

Open
rustam-gamidov-here wants to merge 1 commit intomasterfrom
rga/heresup-50889-introduce-no-content
Open

Introduce ErrorCode::NoContent#1665
rustam-gamidov-here wants to merge 1 commit intomasterfrom
rga/heresup-50889-introduce-no-content

Conversation

@rustam-gamidov-here
Copy link
Collaborator

Allows to distinguish 404 network error and fact that there's no data for the requested resource. This allows to cache NoContent responses and decrease number of such requests

Relates-To: HERESUP-50889

@codecov
Copy link

codecov bot commented Feb 23, 2026

Codecov Report

❌ Patch coverage is 94.44444% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.35%. Comparing base (c08da4f) to head (e6e216c).

Files with missing lines Patch % Lines
...ice-read/src/repositories/PartitionsRepository.cpp 92.59% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1665      +/-   ##
==========================================
+ Coverage   80.33%   80.35%   +0.02%     
==========================================
  Files         350      350              
  Lines       14052    14081      +29     
  Branches     1517     1517              
==========================================
+ Hits        11288    11314      +26     
- Misses       2147     2150       +3     
  Partials      617      617              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@andrey-kashcheev andrey-kashcheev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

Allows to distinguish 404 network error and fact that there's no
data for the requested resource. This allows to cache NoContent
responses and decrease number of such requests

Relates-To: HERESUP-50889
Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants