#247 FitsDict update to work with Chain Map#248
Merged
Conversation
raise KeyError to allow to work with ChainMap
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
random number dependent error fixed
Contributor
Author
ntessore
reviewed
Mar 12, 2025
ntessore
reviewed
Mar 12, 2025
Co-authored-by: Nicolas Tessore <n.tessore@ucl.ac.uk>
Co-authored-by: Nicolas Tessore <n.tessore@ucl.ac.uk>
Contributor
|
Hm, the test failure is due to parallel builds on coveralls not being set up correctly — I will fix that. |
ntessore
force-pushed
the
247-FitsDict-Fix
branch
from
3e489b5 to
dd78c89
Compare
ntessore
force-pushed
the
247-FitsDict-Fix
branch
from
dd78c89 to
42e8be7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
raise KeyError to allow to work with ChainMap
see #247 for details on why we need to raise a KeyError