Use sqltest.Quick and minor improvements #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the test setup for Postgres and Inventory tests by replacing the verbose sqltest.New and pool.Setup calls with the more concise sqltest.Quick helper and removes unused flag imports. Additionally, the integration workflow has been updated to run tests with a shuffled order.
- Simplify test setup using sqltest.Quick in Postgres and Inventory tests.
- Remove unused flag variables.
- Update workflow to enable test shuffling.
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/postgres/postgres_test.go | Replaced manual migration setup with sqltest.Quick and hardcoded Force in one test |
| internal/inventory/inventory_test.go | Removed unused flag variable |
| internal/inventory/helper_test.go | Updated Force parameter to always be true |
| .github/workflows/integration.yml | Added '-shuffle on' to test execution |
Files not reviewed (1)
- go.mod: Language not supported
Comments suppressed due to low confidence (1)
.github/workflows/integration.yml:48
- Ensure that enabling test shuffling does not reveal hidden dependencies between tests. Verify that all tests remain fully independent when run in a shuffled order.
run: go test -v -race -count 1 -shuffle on -covermode atomic -coverprofile=profile.cov ./...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.