[WIP] fix: Add keyword fields to sentence and language_script on crf index #469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def create_entity_index(connection, index_name, doc_type, logger, **kwargs): | ||
| # type: (Elasticsearch, str, str, logging.Logger, **Any) -> None | ||
| def _put_index_mapping(connection, index_name, doc_type, mapping_body, **kwargs): | ||
| # type: (Elasticsearch, str, str, Dict[str, Any], **Any) -> None |
|
Kudos, SonarCloud Quality Gate passed!
|
|
UNIT TESTS HAVE PASSED... Good To Merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to figure a zero-downtime way to migrate mappings and re-index data, possibly will involve code changes to use aliases
JIRA Ticket Number
JIRA TICKET:
Description of change
(REMOVE ME) Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Checklist (OPTIONAL):