Feat/filter types#20
Open
ericges wants to merge 8 commits into
Open
Conversation
…e` to modularize filter handling
…pleEquationFilterType` for extensible filter handling in FlareBundle
…ith assertion style configuration
…in configuration files
…r for improved clarity
ericges
force-pushed
the
feat/filter-types
branch
from
374d0e0 to
43c7da1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a significant refactor of the filter system, focusing on renaming and replacing the
FilterDefinitionconcept withConfiguredFilter, and removing the custom filter invoker attribute/registration system. It also cleans up configuration and code style, and removes now-unnecessary files related to filter invoker registration.Key changes:
Filter System Refactor
Replaced all uses of
FilterDefinitionwithConfiguredFilterthroughout the codebase, including type hints, method signatures, and documentation. The collection class was renamed fromFilterDefinitionCollectiontoConfiguredFilterCollection, with corresponding updates to methods and type annotations. (src/Collection/ConfiguredFilterCollection.php, [1] [2] [3] [4] [5] [6];src/Contract/FilterElement/HydrateFormContract.php, [7];src/Contract/FilterElement/IntrinsicValueContract.php, [8] [9];src/Contract/FilterElement/RuntimeValueContract.php, [10] [11];src/DataContainer/FilterContainer.php, [12] [13] [14] [15]Removed the
AsFilterInvokerattribute and the compiler passRegisterFilterInvokersPass, effectively eliminating custom filter invoker registration via attributes. Related service configuration and autoconfiguration were also cleaned up. (src/DependencyInjection/Attribute/AsFilterInvoker.php, [1];src/DependencyInjection/Compiler/RegisterFilterInvokersPass.php, [2];config/services.yaml, [3];src/DependencyInjection/HeimrichHannotFlareExtension.php, [4] [5]Configuration and Code Style
Updated
mago.tomlto only include thesrc/directory in the source paths and added a rule for assertion style. (mago.toml, [1] [2]Minor code cleanup, such as removing unnecessary comments and ignoring obsolete PHPStan directives. (
src/DependencyInjection/Configuration.php, src/DependencyInjection/Configuration.phpL17)These changes modernize and streamline the filter system, making it more consistent and easier to maintain by relying on the new
ConfiguredFiltermodel and removing legacy invoker registration code.