refactor: consolidate authentication, provider, tenant, and user modules into identity module#175
Merged
danielhe4rt merged 2 commits into4.xfrom Mar 16, 2026
Merged
Conversation
- Move Paginator contract and implementation from He4rt\Shared to App\Contracts and App\Support - Move OAuthClientContract from He4rt\Authentication to App\Contracts - Replace TTL helper class with inline calculations (e.g., 2 * 3600 for hours) - Remove unused UserId value object - Update all module imports to use new App namespace - Register Paginator binding in AppServiceProvider - Update composer.json to remove he4rt/shared dependency
…les into identity module - Create unified identity module with organized subdomains: - Auth: OAuth authentication flow and DTOs - ExternalIdentity: Provider/external identity management (renamed from Provider) - Tenant: Multi-tenancy support - User: User models, actions, and profile management - Rename key classes for clarity: - Provider -> ExternalIdentity - Token -> AccessToken - ProviderEnum -> IdentityProvider - ProviderException -> ExternalIdentityException - Update all module imports across the codebase: - badge, bot-discord, character, events, feedback, integrations - meeting, message, ranking, season, sponsors - Move OAuthClientContract and Paginator to App\Contracts - Remove deprecated modules: authentication, provider, tenant, user - Update composer.json dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
authentication,provider,tenant, andusermodules into a singleidentitymodule for better cohesion and maintainabilitysharedmodule and moves contracts (OAuthClientContract,Paginator) to theappdirectoryChanges
Identity Module Structure
providermodule)Removed Modules
app-modules/authenticationapp-modules/providerapp-modules/tenantapp-modules/userapp-modules/sharedMoved to App Directory
OAuthClientContract→app/Contracts/OAuthClientContract.phpPaginatorcontract →app/Contracts/Paginator.phpPaginatorsupport class →app/Support/Paginator.php