vendor ssh #139
Merged
vendor ssh #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shofetim
approved these changes
Dec 11, 2025
| // Use Bubble Tea ExecProcess to release the terminal during SSH | ||
| cmd := sshutil.SSHCommand(sshHost, sshPort, info.KeyPath) | ||
| return tea.ExecProcess(cmd, func(err error) tea.Msg { | ||
| // Use native SSH client via Bubble Tea Exec |
Contributor
There was a problem hiding this comment.
I don't know why we wrap the SSH in an ExecProcess? but I think the "use native SSH client" part of the comment is out of date.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we vendor the ssh client so that it can work on windows machines