restore the terminal when exiting raw mdoe #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Also now fixes the disconnect |
asebexen
reviewed
Dec 8, 2025
| Args: cobra.MaximumNArgs(1), | ||
| RunE: func(cmd *cobra.Command, args []string) error { | ||
| apiCtx, cancel := context.WithTimeout(context.Background(), application.Timeouts.APIMedium) | ||
| defer cancel() |
Contributor
There was a problem hiding this comment.
This is very funny to me. That would almost certainly cause a forced disconnect after 30 seconds haha.
shofetim
approved these changes
Dec 8, 2025
asebexen
approved these changes
Dec 8, 2025
Contributor
asebexen
left a comment
asebexen
left a comment
There was a problem hiding this comment.
Approved. I believe this also solves what is probably the major cause of https://github.com/hdresearch/chelsea/issues/686; the Medium timeout would cause vers connect to consistently disconnect after 30 seconds, rather than the "once in a while" after 10 seconds in the bug I will be fixing. Confirmed that this fixed both the borked output, as well as the timeout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #133. The issue was that when displaying the ssh connection, we are putting the terminal in raw mode. When the ssh connection was closed unexpectedly, the cli was not restoring the terminal state. We now restore that terminal state :)