Harden PR Builder Dependabot PR builder check#769
Merged
JackPGreen merged 1 commit intohazelcast:masterfrom Mar 23, 2026
Merged
Conversation
The PR builder checks the `github.actor` to determine if it's a Dependabot PR, and if so allows execution. This check is flawed - the `actor` is the user triggering the event, not necessarily the author of the PR - as such it's possible to create an event where the triggering actor is `dependabot` but the codebase is not. Instead, we should check if `dependabot` _authored_ the PR. References: - https://www.synacktiv.com/publications/github-actions-exploitation-dependabot - https://docs.zizmor.sh/audits/#bot-conditions# - [GitHub first-party usage](https://github.com/github/docs/blob/7cbca58400edbc80b22512947ec96563bc984bf1/.github/workflows/triage-unallowed-contributions.yml#L17-L22)
JackPGreen
added a commit
to JackPGreen/hazelcast-wm
that referenced
this pull request
Mar 22, 2026
JackPGreen
added a commit
to JackPGreen/hazelcast-cpp-client
that referenced
this pull request
Mar 22, 2026
JackPGreen
added a commit
to hazelcast/dependabot-automerge
that referenced
this pull request
Mar 22, 2026
JackPGreen
added a commit
to hazelcast/hazelcast-cpp-client
that referenced
this pull request
Mar 23, 2026
JackPGreen
added a commit
to hazelcast/hazelcast-wm
that referenced
this pull request
Mar 23, 2026
JackPGreen
added a commit
to hazelcast/dependabot-automerge
that referenced
this pull request
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR builder checks the
github.actorto determine if it's a Dependabot PR, and if so allows execution.This check is flawed - the
actoris the user triggering the event, not necessarily the author of the PR - as such it's possible to create an event where the triggering actor isdependabotbut the codebase is not. Instead, we should check ifdependabotauthored the PR.References: