Skip to content

Conversation

@aelkiss
Copy link
Member

@aelkiss aelkiss commented May 10, 2024

  • This works reasonably well with Microsoft Narrator for Latin-script languages. (I couldn't get NVDA to automatically switch languages even though it allegedly supports it.)
  • When there is original-script language this seems to work OK
  • Reading Romanized script is pretty bad no matter what; not sure what if anything could be done about that.

If we decided this is worth adopting elsewhere, I'd want to add the html language tag in Solr so that we don't have to duplicate logic for mapping from the MARC language tag, but this at least gives us some idea.

…n MARC 008

* This works reasonably well with Microsoft Narrator for Latin-script
  languages
* When there is original-script language this seems to work
* Reading Romanized script is pretty bad no matter what; not sure what
  if anything could be done about that.

If we decided this is worth adopting elsewhere, I'd want to add the html
language tag in Solr so that we don't have to duplicate logic for
mapping from the MARC language tag, but this at least gives us some
idea.
@aelkiss aelkiss requested review from carylwyatt and moseshll May 10, 2024 19:57
@aelkiss
Copy link
Member Author

aelkiss commented May 10, 2024

Addresses #46, 1727173

@carylwyatt
Copy link
Member

I had VoiceOver read the whole page of this record, and found some little things. None of these are on the a11y audit report, so we don't really need to do anything about it, but I thought I'd note this one here since it's language-related.

VoiceOver did a pretty good job with the languages, as far as I can tell. There's a decent variety on this record via the "similar items" column.

The most annoying thing was the title was read in Romanian (I guess? I don't speak Romanian, so I can't verify that), but then it was read again but in the regular VoiceOver English voice trying to pronounce those words in English? Here's the accessibility tree:
image
It read the "heading" in Romanian, but the spans in English. Maybe we could skip the spans for screen readers? I tried adding aria-hidden=true to the spans as a test, but then it skipped the whole heading.

@carylwyatt
Copy link
Member

I started a list of other screen reader fixes over here

@moseshll
Copy link
Contributor

I have some ideas about how to do this "right" for non-Roman writing systems, but for more universal appeal this approach is hard to beat. I mainly tested this with Japanese and VoiceOver.

@carylwyatt
Copy link
Member

opened new issue for tracking this work #54

@aelkiss
Copy link
Member Author

aelkiss commented Jul 16, 2024

In discussing with @carylwyatt we should apply the language tag on the title even though it has some boilerplate as well -- based on advice from Deque that it's preferable to read the English content incorrectly than the other language. We could consider changing the order of the parts of the title so the title of the book is first followed by catalog record - hathitrust digital library (to be more like pageturner, and to better reflect the different content in the tab title)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants