Skip to content

Use type application in order to simplify rewrite rules for unstreamM #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Shimuuar merged 1 commit into from
Sep 22, 2025
+6 −23
Merged

Use type application in order to simplify rewrite rules for unstreamM #539

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 6 additions & 23 deletions vector/src/Data/Vector/Generic.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2627,19 +2627,11 @@ unstreamPrimM :: (PrimMonad m, Vector v a) => MBundle m u a -> m (v a)
{-# INLINE_FUSED unstreamPrimM #-}
unstreamPrimM s = M.munstream s >>= unsafeFreeze

-- FIXME: the next two functions are only necessary for the specialisations
unstreamPrimM_IO :: Vector v a => MBundle IO u a -> IO (v a)
{-# INLINE unstreamPrimM_IO #-}
unstreamPrimM_IO = unstreamPrimM

unstreamPrimM_ST :: Vector v a => MBundle (ST s) u a -> ST s (v a)
{-# INLINE unstreamPrimM_ST #-}
unstreamPrimM_ST = unstreamPrimM

{-# RULES

"unstreamM[IO]" unstreamM = unstreamPrimM_IO
"unstreamM[ST]" unstreamM = unstreamPrimM_ST #-}
"unstreamM[IO]" unstreamM @IO = unstreamPrimM
"unstreamM[ST]" forall s. forall. unstreamM @(ST s) = unstreamPrimM
#-}



Expand Down Expand Up @@ -2699,14 +2691,6 @@ unsafeGeneratePrim :: (PrimMonad m, Vector v a) => Int -> (Int -> m a) -> m (v a
{-# INLINE unsafeGeneratePrim #-}
unsafeGeneratePrim n f = unsafeFreeze =<< M.generateM n f

generateA_IO :: (Vector v a) => Int -> (Int -> IO a) -> IO (v a)
{-# INLINE generateA_IO #-}
generateA_IO = unsafeGeneratePrim

generateA_ST :: (Vector v a) => Int -> (Int -> ST s a) -> ST s (v a)
{-# INLINE generateA_ST #-}
generateA_ST = unsafeGeneratePrim

-- Identity is used in lest for mapping over structures. So it's
-- relatively important case.
generateA_Identity :: (Vector v a) => Int -> (Int -> Identity a) -> Identity (v a)
Expand All @@ -2715,10 +2699,9 @@ generateA_Identity n f = Identity (generate n (runIdentity . f))


{-# RULES

"generateA[IO]" generateA = generateA_IO
"generateA[ST]" generateA = generateA_ST
"generateA[Identity]" generateA = generateA_Identity
"generateA[IO]" generateA @IO = unsafeGeneratePrim
"generateA[ST]" forall s. forall. generateA @(ST s) = unsafeGeneratePrim
"generateA[Identity]" generateA = generateA_Identity
#-}


Expand Down
Loading