Conversation
Contributor
|
Looks good to me.
adjusted with a permalink to the respective haskell side caller. |
Member
The Haskell-side callers of this file are already stubbed out on this
platform:
- runInteractiveProcess:
https://github.com/haskell/process/blob/e1be5b65eb7a9af6eca567b9f22cb54e7066e634/System/Process/Posix.hs#L274-L291
- terminateProcess, getProcessExitCode, waitForProcess:
https://github.com/haskell/process/blob/e1be5b65eb7a9af6eca567b9f22cb54e7066e634/System/Process.hs#L936-L945
Fixes #357
(cherry picked from commit 72e5b7c75a17f543262674259b2ebf4a3bda390c)
Contributor
Author
|
I have added a comment and amended the commit message. |
Contributor
|
Neat, thanks @wz1000, looks good to me then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also bump base upper bound to < 4.24 for GHC 10.0
I can open a new MR for the base bound bump, but since we don't have CI setup
for wasm32-wasi, it was more convienent to have both changes in a single branch so that
this change can be tested on GHC CI: https://gitlab.haskell.org/ghc/ghc/-/merge_requests/15978
Fixes #357