testsuite: Add process-fork-wait test#179
Open
bgamari wants to merge 2 commits intohaskell:masterfrom
Open
Conversation
bgamari
force-pushed
the
test-fork-wait
branch
3 times, most recently
from
2916537 to
1853eb4
Compare
snoyberg
approved these changes
Jun 1, 2020
Collaborator
snoyberg
left a comment
snoyberg
left a comment
There was a problem hiding this comment.
For these kinds of changes which only affect GHC, I'd rather defer to you to do the merge yourself, so that (1) I don't block GHC dev and (2) it fits into the GHC dev cycle.
Contributor
Author
|
Sure, I would be happy to handle it myself. Thanks for the quick feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test verifies that the
use_process_jobsfeature works asadvertised. Specifically: on Windows
waitForProcessshould not returnuntil all processes created by the child (including those created with
fork) have exited ifuse_process_jobsis enabled.Frankly, this test should have been added long ago.