Document origin coordinates of SourcePos#198
Open
tomsmeding wants to merge 1 commit intohaskell:masterfrom
Open
Document origin coordinates of SourcePos#198tomsmeding wants to merge 1 commit intohaskell:masterfrom
tomsmeding wants to merge 1 commit intohaskell:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every time I use
parsecand I have to do something with source positions, I find theSourcePostype and immediately wonder whether the line and column count from 0 or from 1. This is surprisingly hard to find when casually browsing the haddocks on Hackage: it is here in a non-haddock comment, and in the haddocks of initialPos, which is not exported from the rootText.Parsecmodule.This PR puts the coordinate origin in the haddocks for
SourcePositself to free the user from having to look for it.