Dynamic winio selection for testsuite#613
Merged
Mistuke merged 7 commits intohaskell:masterfrom May 3, 2026
Merged
Conversation
handling of the new recvBufMsgMIO is incorrect and dropped the `WSAEMSGSIZE` checks
mio needs to use safe calls where winio unsafe ones.
Collaborator
Author
|
@kazu-yamamoto can you think of a better way to do the configue check? this is the only thing I could think of. |
Collaborator
|
@Mistuke I don't hit upon another solution. So, shall we merge this PR as is? |
Collaborator
Author
Yeah, I'll do it now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to know that the GHC being used is one with a fixed WinIO signal handling.
To do that we need to test a CPP macro and this is the only way I can think of, cabal doesn't have a way to do such dynamic flags as far as I know.
Also add a bunch of fixups to the accidental changes on MIO with the WINIO changes.