Report target host/port with connection exception#529
Open
yaitskov wants to merge 1 commit intohaskell:masterfrom
Open
Report target host/port with connection exception#529yaitskov wants to merge 1 commit intohaskell:masterfrom
yaitskov wants to merge 1 commit intohaskell:masterfrom
Conversation
…host and port in connection exception
yaitskov
commented
Apr 20, 2022
| connect :: (Show sa, SocketAddress sa) => Socket -> sa -> IO () | ||
| connect s sa = withSocketsDo $ withSocketAddress sa $ \p_sa sz -> | ||
| connectLoop s p_sa (fromIntegral sz) | ||
| connectLoop (show sa) s p_sa (fromIntegral sz) |
Author
There was a problem hiding this comment.
showed socket addr is lazy right? so no problem with that,
though I think SockAddr Show instance is doing too much and might fail due IO and hide original error.
I would fall back to generated Show and move current Show implementation to a new dedicated method of SocketAddress class. I don't know how much legacy would be affected by such refactoring.
Collaborator
There was a problem hiding this comment.
I would like to introduce the Strict pragma someday and don't want to relay on the lazy evaluation. So, what about just passing sa to connectLoop and connectLoop calls show by itself?
Collaborator
|
@yaitskov If you would like to merge this PR, please resolve my comment above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.