fix case #56: Text builder instance writes to wrong offset#57
Open
goertzenator wants to merge 1 commit intohaskell:masterfrom
Open
fix case #56: Text builder instance writes to wrong offset#57goertzenator wants to merge 1 commit intohaskell:masterfrom
goertzenator wants to merge 1 commit intohaskell:masterfrom
Conversation
- use ignored offset parameter in writeN - add property tests for comparing Text/ByteString concatentations to Builder concatentations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes case #56 , Text builder instance writes to wrong offset.
The added test case without the fix gives the failure below. The linked case gives a better sense of what was going wrong here.