synchronize source repos concurrently#9844
Closed
edmundnoble wants to merge 3 commits into
Closed
Conversation
6de4dd9 to
40cd496
Compare
2 tasks
40cd496 to
94f43c4
Compare
and sequenceConcurrentlyBounded_
94f43c4 to
2743ce4
Compare
Collaborator
|
Is this a (partial) duplicate of #10254? |
Contributor
Author
Oh boy, looks like it is. I can close this one then. Thanks @alt-romes for taking this to the finish line. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synchronizes source repos concurrently with 4 repos being synchronized at once. I couldn't find a good way to make this number a flag, and so I figured that if someone wants to do that, they can do it later, because doing this concurrently is already a significant speedup for me and seems to be mostly free.
I didn't write any tests, because I figured this is guaranteed to be correct and I don't know how I'd even test it.
This PR depends on #9843 just because that PR makes it more obvious thatThis no longer depends on #9843.sequenceConcurrentlyBoundedRebuildis correct.QA Notes
Ran this on a work project which has 12 git source repositories. Observed the interleaved output from git and the much faster build from clean.