Fix cabal run's handling of -- under empty target#11786
Open
ulysses4ever wants to merge 1 commit intohaskell:masterfrom
Open
Fix cabal run's handling of -- under empty target#11786ulysses4ever wants to merge 1 commit intohaskell:masterfrom
cabal run's handling of -- under empty target#11786ulysses4ever wants to merge 1 commit intohaskell:masterfrom
Conversation
204ff13 to
5b40dfa
Compare
5b40dfa to
2c72cfb
Compare
ffaf1
approved these changes
May 5, 2026
philderbeast
reviewed
May 6, 2026
philderbeast
reviewed
May 6, 2026
philderbeast
requested changes
May 6, 2026
e91bd54 to
02de5ac
Compare
philderbeast
reviewed
May 7, 2026
philderbeast
reviewed
May 7, 2026
philderbeast
reviewed
May 7, 2026
philderbeast
approved these changes
May 7, 2026
8190b02 to
3703431
Compare
Collaborator
Author
|
i removed the commit touching up the Makefile doctest setup since this issue has been attended to elsewhere |
6a5f949 to
cb107bb
Compare
Collaborator
Author
|
Apparently some of the new tests were incorrect @philderbeast |
Collaborator
The review comment substitution didn't work. It didn't delete lines 3 .. 16 (in what I'm seeing now with cb107bb) that I'd included in the selection for replacement. I think you may also need a type annotation for the opts: + opts1, opts2, opts3 :: [String]
opts1 = ["+RTS"]
opts2 = ["+RTS", "--"]
opts3 = ["--", "+RTS"]You'll also need to run the test with |
Collaborator
Author
|
Thanks, will fix. Also: those opts make tests harder to read imo, so I plan to inline them. |
cb107bb to
2a04e8d
Compare
Before, the number of targets were considered to be 1 always and worked mostly by accident for the empty target when no exe args were supplied. Fixes haskell#10487 Agent-Logs-Url: https://github.com/ulysses4ever/cabal/sessions/b504e919-a7ba-422e-90d2-59528a8e5014 Co-authored-by: ulysses4ever <6832600+ulysses4ever@users.noreply.github.com> Co-authored-by: Phil de Joux <philderbeast@gmail.com> Co-authored-by: Phil de Joux <philderbeast@gmail.com>
2a04e8d to
e775ba8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #10487, created with the help from AI (GitHub Copilot).
Template Α: This PR modifies behaviour or interface
Include the following checklist in your PR:
significance: significantin the changelog file.