Add tests for active-repositories feature#11684
Conversation
|
I asked Claude to give me an idea of the test coverage. Its response:
Where:
|
8a79072 to
335c948
Compare
andreabedini
left a comment
There was a problem hiding this comment.
I left a couple of comments but otherwise LGTM.
Not a deal breaker but any chance you can add a simple test for this edge case behaviour?
-- Note: currently if 'ActiveRepoRest' is provided more than once,
-- rest-repositories will be multiple times in the output.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
A changelog file is missing, here is a suggestion: |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
andreasabel
left a comment
There was a problem hiding this comment.
I am afraid I do not even know what the active-repositories feature is, so I cannot judge this PR.
However, when it comes to tests: the more, the merrier!
|
The documentation for this feature is at: https://cabal.readthedocs.io/en/latest/cabal-project-description-file.html#cfg-field-active-repositories |
This comment was marked as outdated.
This comment was marked as outdated.
b951c21 to
39824b2
Compare
These tests were generated by Claude code, but manually reviewed.
|
@Mergifyio queue |
Merge Queue Status
This pull request spent 10 minutes 33 seconds in the queue, including 1 second running CI. Required conditions to merge
|
This PR only contains tests, which were generated by Claude code, and then manually reviewed. Unfortunately I have not worked much on Cabal so my manual review may not be up-to-scratch.
This PR was submitted in preparation for taking over the work in #8997 and getting it merged. One of the things mentioned in that PR was that need for tests for the
active-repositoriesfeature.Include the following checklist in your PR: