Skip to content

Add ghc-9.14 language extensions#11636

Open
philderbeast wants to merge 3 commits intohaskell:masterfrom
cabalism:add/ghc-9.14-lang-exts
Open

Add ghc-9.14 language extensions#11636
philderbeast wants to merge 3 commits intohaskell:masterfrom
cabalism:add/ghc-9.14-lang-exts

Conversation

@philderbeast
Copy link
Collaborator

@philderbeast philderbeast commented Mar 18, 2026

Fixes #11635. I made similar changes to #10339. The test is the updated md5 check.

Important

Will this need a backport?


@philderbeast philderbeast marked this pull request as draft March 18, 2026 15:48
@philderbeast philderbeast marked this pull request as ready for review March 19, 2026 11:48
@geekosaur
Copy link
Collaborator

I'm inclined to say yes, since it's arguably a bug fix for the cabal version intended to support 9.14.

Also, this is a step in the release documentation. What went wrong, fellow cabalers?

md5CheckGenericPackageDescription :: Proxy GenericPackageDescription -> Assertion
md5CheckGenericPackageDescription proxy = md5Check proxy
0xc039c6741dead5203ad2b33bd3bf4dc8
0xd355021433c2000dbf333e4efd4a800d
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a side note, are these tests useful for anything? I only see them being a constant nuisance, which people automatically rebase to reflect changes to GenericPackageDescription.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests were added in #6255.

The commit, ae33fcf, has this message:

It defines Structured type class, which we use to prepend a hash to cached Binary blobs. Thus we can catch early, if format is changed, avoiding corrupt cache making cabal behave weirdly.

Plenty types got Typeable instances, as it's a superclass of Structured

This commit also introduces new compat modules:

  • Distribution.Compat.Typeable with typeRep
  • Distribution.Client.Compat.Orphans, to collect at least some orphans into central place.

@Bodigrim
Copy link
Collaborator

Will this need a backport?

Absolutely.

@philderbeast philderbeast force-pushed the add/ghc-9.14-lang-exts branch from 84cd4c3 to f63c9ff Compare March 20, 2026 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ExplicitLevelImports and ImplicitStagePersistence extensions

3 participants