Skip to content

Conversation

@sheaf
Copy link
Collaborator

@sheaf sheaf commented Jan 16, 2026

This commit updates the logic in SetupWrapper for determining which installed Cabal unit ID to use. When we are compiling a package with build-type Hooks via an external Setup executable, we need to add a dependency on Cabal. However, we must be sure to use the same version of Cabal that the Cabal-hooks dependency depends on, to avoid #11331.

Fixes #11331

TODO:

  • Fix the test I have added (PackageTests/SetupHooks/T11331). Currently, the test framework doesn't seem to allow changing something like the containers version, expecting it to be pinned. So I'm not sure how to proceed.

Template Α: This PR modifies behaviour or interface

Include the following checklist in your PR:

This commit updates the logic in SetupWrapper for determining which
installed Cabal unit ID to use. When we are compiling a package with
build-type Hooks via an external Setup executable, we need to add a
dependency on Cabal. However, we must be sure to use the same version of
Cabal that the Cabal-hooks dependency depends on, to avoid haskell#11331.

Fixes haskell#11331
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

custom-setup builds fail when constraining dependencies in the Cabal-hooks package stack

1 participant