Hooks: use the appropriate Cabal unit ID #11429
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the logic in SetupWrapper for determining which installed Cabal unit ID to use. When we are compiling a package with build-type Hooks via an external Setup executable, we need to add a dependency on Cabal. However, we must be sure to use the same version of Cabal that the Cabal-hooks dependency depends on, to avoid #11331.
Fixes #11331
TODO:
PackageTests/SetupHooks/T11331). Currently, the test framework doesn't seem to allow changing something like thecontainersversion, expecting it to be pinned. So I'm not sure how to proceed.Template Α: This PR modifies behaviour or interface
Include the following checklist in your PR:
significance: significantin the changelog file.